crypto: fix webcrypto HMAC "get key length" in deriveKey and generateKey#44917
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Oct 12, 2022
Merged
Conversation
panva
added
crypto
Collaborator
|
Review requested:
|
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
panva
force-pushed
the
fix-webcrypto-get-key-length
branch
from
f979ef3 to
7f2258f
Compare
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
jasnell
approved these changes
Oct 10, 2022
Collaborator
panva
added
the
author ready
15 tasks
panva
force-pushed
the
fix-webcrypto-get-key-length
branch
from
7f2258f to
472ae3a
Compare
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
aduh95
approved these changes
Oct 12, 2022
Collaborator
panva
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 214354f |
13 tasks
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #44917 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
PR-URL: #44917 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
panva
added a commit
to panva/node
that referenced
this pull request
Mar 31, 2023
PR-URL: nodejs#44917 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Backport-PR-URL: nodejs#47336
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#42542 unfortunately used the hash's output size instead of block size. This also fixes the same problem for HMAC generateKey when
lengthis missing.Refs: denoland/deno#16180 (comment)
Refs: cloudflare/workerd#68 (comment)